Log device properties to trace file #213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Device properties are useful in any case, but especially for performing analysis on traces such as occupancy. This patch is a re-implementation of pytorch#209 Reviewed By: ilia-cher Differential Revision: D28337067 fbshipit-source-id: b61588b414a9faa6f697260b48f750f013ba553b
gaoteng-git
force-pushed
the
dump_device_props
branch
from
8af5f24 to
e51d028
Compare
gaoteng-git
force-pushed
the
dump_device_props
branch
from
e51d028 to
493d301
Compare
gaoteng-git
force-pushed
the
dump_device_props
branch
from
493d301 to
e14376e
Compare
guotuofeng
suggested changes
May 11, 2021
|
|
||
| #ifdef HAS_CUPTI | ||
| traceOf_ << fmt::format(R"JSON( | ||
| "computeProperties": [ |
There was a problem hiding this comment.
need confirm with @gdankel about using top level property or putting it into metadata.
My personal preference is put it into metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device properties are useful in any case, but especially for performing analysis on traces such as occupancy.
This patch is a re-implementation of #209
And it added 2 fields "name" and "totalGlobalMem", to remove duplicate from PyTorch side dump.
It adds "ifdef" to ignore dumping these fields when build on pure cpu.