Skip to content

workaround for negative gpu metrics from input json file #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2021
Merged

workaround for negative gpu metrics from input json file #330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bf6ab2
workaround for negative gpu metrics from input json file
gaoteng-git Jun 29, 2021
8b6b3e4
refine
gaoteng-git Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions tb_plugin/torch_tb_profiler/profiler/gpu_metrics_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,20 @@ def parse_event(self, event):
if gpu_id not in self.gpu_ids:
self.gpu_ids.add(gpu_id)
self.kernel_ranges_per_device[gpu_id].append((ts, ts + dur))
self.blocks_per_sm_per_device[gpu_id].append((ts, ts + dur, event.args.get("blocks per SM", 0.0)))
self.occupancy_per_device[gpu_id].append((ts, ts + dur,
event.args.get("est. achieved occupancy %", 0.0)))
if "blocks per SM" in event.args:
self.blocks_per_sm_count[gpu_id] += 1
blocks_per_sm = event.args.get("blocks per SM")
if blocks_per_sm > 0.0:
self.blocks_per_sm_per_device[gpu_id].append((ts, ts + dur, blocks_per_sm))
self.blocks_per_sm_count[gpu_id] += 1
else:
# Workaround for negative value input.
logger.warning("blocks per SM {} with ts {} is not positive!".format(blocks_per_sm, ts))

if "est. achieved occupancy %" in event.args:
self.occupancy_count[gpu_id] += 1
occupancy = event.args.get("est. achieved occupancy %")
if occupancy >= 0.0:
self.occupancy_per_device[gpu_id].append((ts, ts + dur, occupancy))
self.occupancy_count[gpu_id] += 1
else:
# Workaround for negative value input.
logger.warning("est. achieved occupancy % {} with ts {} is negative!".format(occupancy, ts))