Refactor 4/n: Simplify activity logger step 2/3 #466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 11, 2021
Summary: Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 90f5f126256139af92c729daf98b672151bf92b9
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
force-pushed
the
export-D31624496
branch
from
79cb08c to
ca3d7b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 12, 2021
Summary: Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 8b066f068e4187798a30bb6eef50e4e6957fa0c5
gdankel
force-pushed
the
export-D31624496
branch
from
ca3d7b0 to
341773e
Compare
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 12, 2021
Summary: Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: c41d65541c111c5f7b800a1816058a5c3ecc9c95
gdankel
force-pushed
the
export-D31624496
branch
from
341773e to
714b935
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 14, 2021
Summary: Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 3f7b662cae038904544a46905d43e5e53d6910fe
gdankel
force-pushed
the
export-D31624496
branch
from
714b935 to
2218c2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 15, 2021
Summary: Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 356d5df0be17c8862d9d3e8df25e0fddab2a8c29
gdankel
force-pushed
the
export-D31624496
branch
from
2218c2c to
2d43ec9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 15, 2021
Summary: Pull Request resolved: pytorch/pytorch#68329 Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: be721e0171210f29935e9483c0ce0c5589004842
gdankel
force-pushed
the
export-D31624496
branch
from
2d43ec9 to
afbf2e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/kineto
that referenced
this pull request
Nov 18, 2021
Summary: Pull Request resolved: pytorch/pytorch#68329 Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 76298cb01c81925e72c3c2d004cc6f2c5637763f
gdankel
force-pushed
the
export-D31624496
branch
from
afbf2e9 to
f0eb8cd
Compare
Summary: Pull Request resolved: pytorch/pytorch#68329 Pull Request resolved: pytorch#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 0c4b063c64614c01e73d2b6a2ba93188aeafa43a
gdankel
force-pushed
the
export-D31624496
branch
from
f0eb8cd to
05bb363
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31624496 |
gdankel
added a commit
to gdankel/pytorch
that referenced
this pull request
Nov 18, 2021
…68329) Summary: Pull Request resolved: pytorch#68329 Pull Request resolved: pytorch/kineto#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: 5766f72333b813ef2859412471c3256f7c570f90
|
This pull request has been merged in bc4eaef. |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 19, 2021
Summary: Pull Request resolved: #68329 Pull Request resolved: pytorch/kineto#466 1. Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities. This primarily involves enabling generic support for CPU -> GPU flows. 2. In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section. Reviewed By: briancoutinho Differential Revision: D31624496 fbshipit-source-id: dab04b3e3c0dd6799496ac87f837363de79eea25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Generalize ChromeTraceLogger::handleGenericActivity to enable it to handle Cuda runtime activities as well as the Roctracer generic activities.
This primarily involves enabling generic support for CPU -> GPU flows.
In the event of out-of-order GPU activities (an issue with Cuda11.0, likely fixed in later versions), no longer remove them but print warnings. Another diff will add these warnings to the metadata section.
Reviewed By: briancoutinho
Differential Revision: D31624496