Skip to content
This repository was archived by the owner on Nov 10, 2022. It is now read-only.

Conversation

george-qi
Copy link
Contributor

@george-qi george-qi commented Jun 17, 2022

Stack from ghstack (oldest at bottom):

Differential Revision: D37257029

[ghstack-poisoned]
george-qi added a commit that referenced this pull request Jun 17, 2022
ghstack-source-id: 9596bee
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jun 17, 2022
ghstack-source-id: 9576da2
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jun 17, 2022
ghstack-source-id: 5396c73
Pull Request resolved: #67
@george-qi
Copy link
Contributor Author

@george-qi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this tutorial looks great! I'm mostly adding comments on phrasing and some clarifications on my end, so please view this more as a discussion.


+++

Unfortunately, only reductions across all dimensions are supported and not a particular dimension (e.g. `mt.sum()` is supported but not `mt.sum(dim=1)`). For a list of supported reductions, please refer [here](https://pytorch.org/maskedtensor/main/reductions.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be the case anymore by using _masked reductions

george-qi added a commit that referenced this pull request Jul 7, 2022
ghstack-source-id: c7148fc
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 7, 2022
ghstack-source-id: 055c2fe
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 7, 2022
ghstack-source-id: 7d3b0fd
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 7, 2022
ghstack-source-id: e0145f9
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 8, 2022
ghstack-source-id: 453021b
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 8, 2022
ghstack-source-id: b17236c
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 8, 2022
ghstack-source-id: e32b097
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 8, 2022
ghstack-source-id: b006537
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 8, 2022
ghstack-source-id: 662944b
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 13, 2022
ghstack-source-id: fa5593f
Pull Request resolved: #67
george-qi added a commit that referenced this pull request Jul 13, 2022
ghstack-source-id: 903c0f9
Pull Request resolved: #67
@george-qi
Copy link
Contributor Author

@george-qi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/george-qi/35/head branch July 17, 2022 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants