-
Notifications
You must be signed in to change notification settings - Fork 21
Add permission fix before checkout #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @xuechendi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
root Signed-off-by: Chendi Xue <chendi.xue@intel.com>
louie-tsai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for identifying the root cause and creating the fix
Issue:
CPU docker is with root permission and it will write

resultsto host as rootIn that next, since _work folder contains 'root' files, it will hit permission error like below
To fix this, will try to do a permission fix before checkout.
I verified with multiple situation
Conclusion
This PR should not bring side-effect to existing platform, but bring a new fix for any platform which uses ROOT in docker but using non-ROOT to launch github action