Skip to content

[HPU][BENCHMARK-CI] Fix Gaudi docker image check by using similiar codes as rest #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2025
Merged

[HPU][BENCHMARK-CI] Fix Gaudi docker image check by using similiar codes as rest #99

merged 2 commits into from
Nov 1, 2025

Conversation

@xuechendi
Copy link
Contributor

@xuechendi xuechendi commented Oct 31, 2025

No description provided.

@xuechendi
Fix /tmp/vllm-gaudi exists issue
4dfac28 
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
@meta-cla meta-cla bot added the cla signed label Oct 31, 2025
@xuechendi xuechendi closed this Nov 1, 2025
@xuechendi
remove special handling for HPU docker image tag
53f63a5 
Same fix is done in vllm-ci-infra as well

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
@xuechendi xuechendi reopened this Nov 1, 2025
@xuechendi xuechendi changed the title [HPU][BENCHMARK-CI] Fix /tmp/vllm-gaudi exists issue [HPU][BENCHMARK-CI] Fix Gaudi docker image check by using similiar codes as rest Nov 1, 2025
huydhn
huydhn reviewed Nov 1, 2025
View reviewed changes
.github/workflows/vllm-benchmark.yml
DEVICE_TYPE=$(rocminfo | grep "Marketing Name" | tail -n1 | awk -F':' '{print $2}' | xargs)
elif [[ "${DEVICE_NAME}" == "hpu" ]]; then
DEVICE_TYPE=$(hl-smi -q | grep "Product Name" | head -n 1 | awk -F ':' '{print $2}' | sed 's/^ *//')
DEVICE_TYPE="Intel Gaudi3 "$(hl-smi -q | grep "Product Name" | head -n 1 | awk -F ':' '{print $2}' | sed 's/^ *//')
Copy link
Contributor

@huydhn huydhn Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird to see this name hard coded here, but I guess it's ok if you think it's the best way to get this information at the moment

@huydhn huydhn merged commit adef44d into pytorch:main Nov 1, 2025
3 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuechendi @huydhn