Skip to content

[pipelining] stage only stores most recent backward result #139404

@wconstab

Description

@wconstab

In theory this means that reordering backward calls and then sending their activations could give wrong results. In practice we don't have any tests that seem to do this. But in forward, we store each activation indexed b microbatch_id, and we should probably do the same for backward and add a test for this edge case.

Metadata

Metadata

Assignees

Labels

module: pipeliningPipeline ParallelismtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions