-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Closed
Labels
module: bootcampWe plan to do a full writeup on the issue, and then get someone to do it for onboardingWe plan to do a full writeup on the issue, and then get someone to do it for onboardingoncall: jitAdd this issue/PR to JIT oncall triage queueAdd this issue/PR to JIT oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Background
JIT recently added a feature that allows a Module
to be lowered for execution on a non-JIT specialized backend, such as Glow. The API for declaring specialized backends is in torch/csrc/jit/backends/backend.h
. However, there is code in there that is not templated (e.g. getPreprocessSchema
) and does not need to be in that header. Its continued presence can be confusing for end-users.
The Task
Move this code that does not need to be in backend.h
into a detail
namespace in a separate header or into a separate cpp file.
How to Test
python test/test_jit.py TestBackends
cc @suo
Metadata
Metadata
Assignees
Labels
module: bootcampWe plan to do a full writeup on the issue, and then get someone to do it for onboardingWe plan to do a full writeup on the issue, and then get someone to do it for onboardingoncall: jitAdd this issue/PR to JIT oncall triage queueAdd this issue/PR to JIT oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module