Add default arguments to cuda stream and events #53025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 564b408 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
SplitInfinity
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #53025 +/- ##
==========================================
- Coverage 78.01% 78.01% -0.01%
==========================================
Files 1848 1848
Lines 179696 179696
==========================================
- Hits 140192 140185 -7
- Misses 39504 39511 +7 |
…orch into new_add_default_args
There was a problem hiding this comment.
@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@nikithamalgifb merged this pull request in ab7f6f3. |
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: * **pytorch#53025 Add default args for CUDA stream and events** Tests: ===== python test/test_jit.py -v TestCUDA Pull Request resolved: pytorch#53025 Reviewed By: H-Huang Differential Revision: D26734499 Pulled By: nikithamalgifb fbshipit-source-id: 5311623a501e2e6fb3fc70e39522e3970e401feb
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: * **pytorch#53025 Add default args for CUDA stream and events** Tests: ===== python test/test_jit.py -v TestCUDA Pull Request resolved: pytorch#53025 Reviewed By: H-Huang Differential Revision: D26734499 Pulled By: nikithamalgifb fbshipit-source-id: 5311623a501e2e6fb3fc70e39522e3970e401feb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests:
python test/test_jit.py -v TestCUDA