Build and push Docker images in GitHub Actions #58174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 76b0b34 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced May 12, 2021
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
Evidence that this works:
|
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
approved these changes
May 14, 2021
| echo "::set-output name=docker_image::${DOCKER_IMAGE_BASE}:${DOCKER_TAG}" | ||
| - name: Check if image should be built | ||
| id: check | ||
| env: |
There was a problem hiding this comment.
question, do we know why we dont need the AWS_* environment variable here?
There was a problem hiding this comment.
yeah afaik it's because our custom runners have IAM access automatically; @seemethere knows more about this though
|
Reverting because this broke |
|
This pull request has been reverted by e6adc06. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2021
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#58174 Test Plan: Imported from OSS Reviewed By: walterddr Differential Revision: D28425179 Pulled By: samestep fbshipit-source-id: acea02d300c2547ced55e0e5586e95a6b5e1876d
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This is a reland of pytorch#58174. Pull Request resolved: pytorch#58299 Reviewed By: malfet, seemethere, janeyx99 Differential Revision: D28445451 Pulled By: samestep fbshipit-source-id: 2654118fe80f50bbdaaad9b7ee58dfd8ef25980d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D28425179