Skip to content

Builder repo is not pinned in release branch #72655

@malfet

Description

@malfet

🐛 Describe the bug

I've noticed that #72217 configures only old CircleCI builds to point to https://github.com/pytorch/builder/tree/release/1.11 , while new GHA builds keep using main branch of https://github.com/pytorch/builder/

I think it needs to be remedied by landing 2 changes: One to main branch of PyTorch that adds ability to specify branch to

{%- macro checkout(submodules="recursive", deep_clone=True, directory="", repository="pytorch/pytorch") -%}

and update https://github.com/pytorch/pytorch/blob/master/RELEASE.md to mention that changes need to happen in two templates mentioned below
After this is done, in release specific PR that select release/1.11 branch in
!{{ common.checkout(deep_clone=False, directory="builder", repository="pytorch/builder") }}

and

Versions

1.11-RC0

cc @ezyang @gchanan @zou3519

Metadata

Metadata

Assignees

Labels

high priorityoncall: relengIn support of CI and Release EngineeringtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions