test_neg_conj_view_istft_cpu_complex128 fails on DEBUG=1

[eellison]

🐛 Describe the bug

python test/test_ops.py -k test_neg_conj_view_istft_cpu_complex128

ERROR: test_neg_conj_view_istft_cpu_complex128 (main.TestMathBitsCPU)
Traceback (most recent call last):
File "/private/home/eellison/anaconda3/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 390, in instantiated_test
raise rte
File "/private/home/eellison/anaconda3/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 377, in instantiated_test
result = test(self, **param_kwargs)
File "/private/home/eellison/anaconda3/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 821, in dep_fn
return fn(slf, *args, **kwargs)
File "/private/home/eellison/anaconda3/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 786, in test_wrapper
return test(*args, **kwargs)
File "test/test_ops.py", line 1418, in test_neg_conj_view
self._test_math_view(
File "test/test_ops.py", line 1299, in _test_math_view
forward_with_mathview = op(cloned1, *sample.args, **sample.kwargs)
File "/private/home/eellison/anaconda3/lib/python3.8/site-packages/torch/testing/_internal/common_methods_invocations.py", line 952, in call
return self.op(*args, **kwargs)
RuntimeError: !self.is_neg() INTERNAL ASSERT FAILED at "../aten/src/ATen/native/UnaryOps.cpp":491, please report a bug to PyTorch.

Related: #78519 #78635

Versions

master

cc @ezyang @anjali411 @dylanbespalko @mruberry @lezcano @nikitaved @peterbell10

[anjali411]

somehow this test is generating a complex tensor with a neg bit which we thought is not possible to get through our public API ...

pytorch/aten/src/ATen/native/UnaryOps.cpp

Lines 488 to 490 in 9acbaaa

	// currently a tensor should never have both conj and neg bit set
	// the only way to get an imag bit is complex_tensor.conj().imag but there's
	// no intended designed mechanism to enter the complex world with this imag bit

I wonder if those macros should be TORCH_INTERNAL_ASSERT instead of TORCH_INTERNAL_ASSERT_DEBUG_ONLY

[VitalyFedyunin]

@anjali411 is it safe to assume complex module?

[peterbell10]

Is the assert actually adding value here? self.clone() will resolve a negative conjugated tensor correctly, so we're looking for a situation where the user wants the neg bit to still be set on the output.