-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Closed
Labels
better-engineeringRelatively self-contained tasks for better engineering contributorsRelatively self-contained tasks for better engineering contributorshigh prioritymodule: fsdpmodule: optimizerRelated to torch.optimRelated to torch.optimoncall: distributedAdd this issue/PR to distributed oncall triage queueAdd this issue/PR to distributed oncall triage queuetriage review
Description
🚀 The feature, motivation and pitch
https://github.com/pytorch/pytorch/blob/master/test/distributed/_composable/fully_shard/test_fully_shard_optim_checkpoint.py are unittests for fully_shard + optim checkpoint, but these do not appear to actually test the load API.
Marking as high pri due to the composability effort requiring this.
Alternatives
No response
Additional context
No response
cc @ezyang @gchanan @zou3519 @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @vincentqb @jbschlosser @albanD @janeyx99
Metadata
Metadata
Assignees
Labels
better-engineeringRelatively self-contained tasks for better engineering contributorsRelatively self-contained tasks for better engineering contributorshigh prioritymodule: fsdpmodule: optimizerRelated to torch.optimRelated to torch.optimoncall: distributedAdd this issue/PR to distributed oncall triage queueAdd this issue/PR to distributed oncall triage queuetriage review