-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Closed
Labels
module: buildBuild system issuesBuild system issuesmodule: devxRelated to PyTorch contribution experience (HUD, pytorchbot)Related to PyTorch contribution experience (HUD, pytorchbot)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
#96668 (comment) had to be reverted since it caused an internal failure (due to a missing newline) when the external, github build showed no problems
Ask: Investigate the discrepancy and modify either the internal or external builds to match the other one (most likely we'll modify the external one)
Note: this is prob be a C++ compiler flag mismatch issue, not a linter error. The exact failure was:
torch/csrc/api/include/torch/mps.h:21:21: error: no newline at end of file [-Werror,-Wnewline-eof]
} // namespace torch
(source)
Perhaps we need to add the -Wnewline-eof
flag to our external C++ compiler
Metadata
Metadata
Assignees
Labels
module: buildBuild system issuesBuild system issuesmodule: devxRelated to PyTorch contribution experience (HUD, pytorchbot)Related to PyTorch contribution experience (HUD, pytorchbot)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Type
Projects
Status
Done