Skip to content

Discrepancy in Internal/external newline-at-end-of-file behavior for C++ files #96747

@ZainRizvi

Description

@ZainRizvi

🐛 Describe the bug

#96668 (comment) had to be reverted since it caused an internal failure (due to a missing newline) when the external, github build showed no problems

Ask: Investigate the discrepancy and modify either the internal or external builds to match the other one (most likely we'll modify the external one)

Note: this is prob be a C++ compiler flag mismatch issue, not a linter error. The exact failure was:

torch/csrc/api/include/torch/mps.h:21:21: error: no newline at end of file [-Werror,-Wnewline-eof]
} // namespace torch

(source)

Perhaps we need to add the -Wnewline-eof flag to our external C++ compiler

cc @malfet @seemethere @kit1980 @huydhn @clee2000

Metadata

Metadata

Assignees

Labels

module: buildBuild system issuesmodule: devxRelated to PyTorch contribution experience (HUD, pytorchbot)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions