[dynamo] Make bytecode logging off-by-default #100093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A big model (like Meta's production models) can dump 100s of MBs of bytecode, making the logs virtually unusable. Let's only turn these on if they're explicitly requested. Differential Revision: [D45314055](https://our.internmc.facebook.com/intern/diff/D45314055/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100093
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1a93ff7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bertmaher
added a commit
that referenced
this pull request
Apr 26, 2023
A big model (like Meta's production models) can dump 100s of MBs of bytecode, making the logs virtually unusable. Let's only turn these on if they're explicitly requested. Differential Revision: [D45314055](https://our.internmc.facebook.com/intern/diff/D45314055/) ghstack-source-id: 187203196 Pull Request resolved: #100093
A big model (like Meta's production models) can dump 100s of MBs of bytecode, making the logs virtually unusable. Let's only turn these on if they're explicitly requested. Differential Revision: [D45314055](https://our.internmc.facebook.com/intern/diff/D45314055/) cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
mlazos
approved these changes
Apr 26, 2023
A big model (like Meta's production models) can dump 100s of MBs of bytecode, making the logs virtually unusable. Let's only turn these on if they're explicitly requested. Differential Revision: [D45314055](https://our.internmc.facebook.com/intern/diff/D45314055/) cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
A big model (like Meta's production models) can dump 100s of MBs of
bytecode, making the logs virtually unusable. Let's only turn these on if
they're explicitly requested.
Differential Revision: D45314055
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire