[lite interpreter][hack] Add batch_norm_update_stats if batchnorm and training are present #100134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

JacobSzwejbka wants to merge 1 commit into pytorch:main from JacobSzwejbka:export-D45335791

Contributor

JacobSzwejbka commented Apr 26, 2023

Summary: not sure how the train bool to batch_norm gets set. But its not the is_training module level flag. We get weird behavior for teams trying to do on device training because of this

Test Plan: ci

Differential Revision: D45335791

pytorch-bot bot added the release notes: mobile label

pytorch-bot bot commented Apr 26, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100134

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 9e5e611:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45335791

larryliu0820 approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45335791

JacobSzwejbka force-pushed the export-D45335791 branch from 11394d6 to 982063a Compare

April 27, 2023 18:06

JacobSzwejbka force-pushed the export-D45335791 branch from 982063a to 4ff50e7 Compare

April 27, 2023 19:07

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45335791

JacobSzwejbka force-pushed the export-D45335791 branch from 4ff50e7 to 5db9d8d Compare

April 28, 2023 21:35

Contributor

facebook-github-bot commented Apr 28, 2023

This pull request was exported from Phabricator. Differential Revision: D45335791

JacobSzwejbka force-pushed the export-D45335791 branch from 5db9d8d to cfb8f4c Compare

April 28, 2023 21:43

Contributor

facebook-github-bot commented Apr 28, 2023

This pull request was exported from Phabricator. Differential Revision: D45335791


          [lite interpreter][hack] Add batch_norm_update_stats if batchnorm and…

9e5e611

… training are present (pytorch#100134)

Summary:
Pull Request resolved: pytorch#100134

not sure how the train bool to batch_norm gets set. But its not the is_training module level flag. We get weird behavior for teams trying to do on device training because of this

Test Plan: ci

Reviewed By: Jack-Khuu

Differential Revision: D45335791

fbshipit-source-id: 726272178cf4b3ecb17a57e7937d9211ad465b50

JacobSzwejbka force-pushed the export-D45335791 branch from cfb8f4c to 9e5e611 Compare

April 28, 2023 23:29

Contributor

facebook-github-bot commented Apr 28, 2023

This pull request was exported from Phabricator. Differential Revision: D45335791

Contributor Author

JacobSzwejbka commented May 1, 2023

@pytorchbot merge

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented May 1, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

fd82f11

valentinandrei pushed a commit to valentinandrei/pytorch that referenced this pull request


          [lite interpreter][hack] Add batch_norm_update_stats if batchnorm and…

5f37887

… training are present (pytorch#100134)

Summary: not sure how the train bool to batch_norm gets set. But its not the is_training module level flag. We get weird behavior for teams trying to do on device training because of this

Test Plan: ci

Differential Revision: D45335791

Pull Request resolved: pytorch#100134
Approved by: https://github.com/larryliu0820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged merging release notes: mobile