Skip to content

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Apr 27, 2023

Fixes #ISSUE_NUMBER

  • change hook so that test still gets saved in --sc when fails in test setup (caused an off by 1 error due to setup being called before the logreport hook)
  • allow reruns for all tests now that --sc is used
  • increase number of reruns now that --sc is used

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100200

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 89261f3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 marked this pull request as ready for review April 28, 2023 17:05
@clee2000 clee2000 requested a review from a team as a code owner April 28, 2023 17:05

def pytest_runtest_logreport(self, report: TestReport) -> None:
self.lastrun = report.nodeid
def pytest_runtest_protocol(self, item, nextitem) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so this would write the last test run before crashing

@clee2000
Copy link
Contributor Author

@pytorchbot merge -f "no further testing required"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants