[Doc] Add sum reduction for CTCLoss #100235

isdanni · 2023-04-28T07:52:23Z

Summary:

Reference:

pytorch/aten/src/ATen/native/LossCTC.cpp

Lines 366 to 371 in 39b885c

    
           if (reduction == Reduction::Mean) { 
        
             auto target_lengths_t = at::tensor(target_lengths, res.options()); 
        
             return (res / target_lengths_t).mean(); 
        
           } else if (reduction == Reduction::Sum) { 
        
             return res.sum(); 
        
           }

Test Plan: See GitHub Tests.

Differential Revision: D45387774

pytorch-bot · 2023-04-28T07:52:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100235

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit b731318:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

linux-bionic-cuda12.1-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-04-28T07:53:15Z

This pull request was exported from Phabricator. Differential Revision: D45387774

albanD

Thanks!

mikaylagawarecki

Thanks @isdanni

nit: could you also update the documentation for the shape of output per the comment on the linked issue please :)

isdanni · 2023-04-28T18:01:40Z

Thanks @isdanni

nit: could you also update the documentation for the shape of output per the comment on the linked issue please :)

Updated. I think the original output doc scalar just meant scalar by default(a.k.a. if reduction is mean or sum) but it might be a bit unclear. I add a if statement to explain further :)

facebook-github-bot · 2023-04-28T18:02:10Z

This pull request was exported from Phabricator. Differential Revision: D45387774

mikaylagawarecki

Ah I missed that first scalar! Thank you so much for clarifying the docs! :)

github-actions · 2023-06-27T22:34:58Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

mikaylagawarecki · 2023-06-28T01:26:50Z

@pytorchbot rebase

pytorchmergebot · 2023-06-28T01:29:35Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-06-28T01:29:49Z

Successfully rebased export-D45387774 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout export-D45387774 && git pull --rebase)

mikaylagawarecki · 2023-06-28T13:46:41Z

@pytorchbot merge -f "build failures are unrelated"

pytorchmergebot · 2023-06-28T13:48:26Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-06-28T13:48:29Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

Raised by workflow job

Summary: Pull Request resolved: pytorch#100235 Reference: https://github.com/pytorch/pytorch/blob/39b885cbbfc8c115069d49f5a6d27ea622bd05dc/aten/src/ATen/native/LossCTC.cpp#L366-L371 Test Plan: See GitHub Tests. Differential Revision: D45387774 fbshipit-source-id: 8166f5ea0383312bce0df2d9ea53aed2edf551b4

facebook-github-bot · 2023-06-28T15:49:48Z

This pull request was exported from Phabricator. Differential Revision: D45387774

isdanni · 2023-06-28T15:51:55Z

Thanks for merging this @mikaylagawarecki My other PR had a similar problem. Rebasing and export from Phabricator should do the trick.

mikaylagawarecki · 2023-06-28T16:05:32Z

@pytorchbot merge -f "build failure is unrelated"

pytorchmergebot · 2023-06-28T16:08:16Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

isdanni requested review from albanD, jbschlosser and mikaylagawarecki as code owners April 28, 2023 07:52

facebook-github-bot added the fb-exported label Apr 28, 2023

albanD approved these changes Apr 28, 2023

View reviewed changes

mikaylagawarecki reviewed Apr 28, 2023

View reviewed changes

mikaylagawarecki added release notes: nn release notes category topic: docs topic category labels Apr 28, 2023

isdanni force-pushed the export-D45387774 branch from 978995a to 784739f Compare April 28, 2023 18:02

mikaylagawarecki approved these changes Apr 28, 2023

View reviewed changes

github-actions bot added the Stale label Jun 27, 2023

mikaylagawarecki removed the Stale label Jun 28, 2023

pytorchmergebot force-pushed the export-D45387774 branch from 784739f to 5f849ad Compare June 28, 2023 01:29

pytorchmergebot added the merging label Jun 28, 2023

pytorchmergebot removed the merging label Jun 28, 2023

isdanni force-pushed the export-D45387774 branch from 5f849ad to b731318 Compare June 28, 2023 15:49

pytorchmergebot added merging Merged and removed merging labels Jun 28, 2023

pytorchmergebot closed this in 35a8242 Jun 28, 2023

	if (reduction == Reduction::Mean) {
	auto target_lengths_t = at::tensor(target_lengths, res.options());
	return (res / target_lengths_t).mean();
	} else if (reduction == Reduction::Sum) {
	return res.sum();
	}

[Doc] Add sum reduction for CTCLoss #100235

[Doc] Add sum reduction for CTCLoss #100235

Uh oh!

Conversation

isdanni commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100235

✅ 1 Unrelated Failure

Uh oh!

facebook-github-bot commented Apr 28, 2023

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

mikaylagawarecki left a comment

Choose a reason for hiding this comment

Uh oh!

isdanni commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 28, 2023

Uh oh!

mikaylagawarecki left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 27, 2023

Uh oh!

mikaylagawarecki commented Jun 28, 2023

Uh oh!

pytorchmergebot commented Jun 28, 2023

Uh oh!

pytorchmergebot commented Jun 28, 2023

Uh oh!

mikaylagawarecki commented Jun 28, 2023

Uh oh!

pytorchmergebot commented Jun 28, 2023

Merge started

Uh oh!

pytorchmergebot commented Jun 28, 2023

Merge failed

Uh oh!

facebook-github-bot commented Jun 28, 2023

Uh oh!

isdanni commented Jun 28, 2023

Uh oh!

mikaylagawarecki commented Jun 28, 2023

Uh oh!

pytorchmergebot commented Jun 28, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isdanni commented Apr 28, 2023 •

edited

Loading

pytorch-bot bot commented Apr 28, 2023 •

edited

Loading

isdanni commented Apr 28, 2023 •

edited

Loading