Skip to content

inplace PyTorchStreamReader getRecord() #100418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

inplace PyTorchStreamReader getRecord() #100418

wants to merge 1 commit into from

Conversation

jiayisuse
Copy link
Contributor

@jiayisuse jiayisuse commented May 1, 2023 •
edited
Loading

Summary: Sometimes we want to getRecord into an pre-allocated memory to save cpu memory. Adding new API to support the inplace memory writing.

Test Plan: caffe2/serialize/inline_container_test

Reviewed By: zyan0

Differential Revision: D45439517

@jiayisuse @facebook-github-bot
inplace PyTorchStreamReader getRecord()
1d52536 
Summary: Sometimes we want to getRecord into an pre-allocated memory to save cpu memory. Adding new API to support the inplace memory writing.

Test Plan: /data/users/jiayisuse/fbsource/buck-out/v2/gen/fbcode/caffe2/caffe2/serialize/inline_container_test

Reviewed By: zyan0

Differential Revision: D45439517

fbshipit-source-id: 51ef8c29dce67482f4ecac70013a256e36947021
@pytorch-bot
Copy link

pytorch-bot bot commented May 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100418

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 1d52536:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 1, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the caffe2 label May 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45439517

@zyan0 zyan0 requested review from davidberard98 and suo May 1, 2023 21:44
@davidberard98
Copy link
Contributor

/easycla

houseroad
houseroad approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 3, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'nn(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorch-bot
Copy link

pytorch-bot bot commented May 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@huydhn
Copy link
Contributor

huydhn commented May 4, 2023

/easycla

@huydhn
Copy link
Contributor

huydhn commented May 4, 2023

@pytorchbot merge -f 'Landed internally'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

@suo suo Awaiting requested review from suo

+1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

caffe2 fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jiayisuse @facebook-github-bot @davidberard98 @huydhn @pytorchmergebot @houseroad