Fix AT_USE_JITERATOR checks #100464

peterbell10 · 2023-05-02T12:38:13Z

Stack from ghstack (oldest at bottom):

-> Fix AT_USE_JITERATOR checks #100464

AT_USE_JITERATOR evaluates to false when the definition isn't
included, so these files were not using jiterator at all.

pytorch-bot · 2023-05-02T12:38:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100464

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 065ee34:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: be1e006 Pull Request resolved: #100464

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: be1e006 Pull Request resolved: pytorch#100464

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: 8018036 Pull Request resolved: #100464

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: 09fade4 Pull Request resolved: #100464

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

peterbell10 · 2023-05-05T21:58:50Z

aten/src/ATen/native/cuda/UnaryGeometricAcosKernel.cu

 namespace at::native {

-CONSTEXPR_EXCEPT_WIN_CUDA char acos_name[] = "acos";
+CONSTEXPR_EXCEPT_WIN_CUDA char acos_name[] = "acos_impl";


The _impl is necessary because otherwise it calls acos defined in the jiterator headers which fails because the template parameters are different. Same issue exists for all of these.

peterbell10 · 2023-05-05T21:59:20Z

aten/src/ATen/native/cuda/UnaryGeometricAcosKernel.cu

  auto common_dtype = iter.common_dtype();
  if (at::isComplexType(common_dtype)) {
-#if AT_USE_JITERATOR
+    // Disabled due to accuracy issues


Some of these might just need tolerance bumps, but I didn't want to spend much time on this.

Could you open an issue describing what would need doing and tag it as "good first issue"?

Opened #100842

lezcano

Good catch!

Is there any way we could have a regression test for this (even if it's xfailed for now, given that all these are deactivated now).

Also cc @kshitij12345 as he probably wrote a few of these.

lezcano · 2023-05-06T11:36:41Z

aten/src/ATen/native/cuda/UnaryGeometricAcosKernel.cu

  auto common_dtype = iter.common_dtype();
  if (at::isComplexType(common_dtype)) {
-#if AT_USE_JITERATOR
+    // Disabled due to accuracy issues


Could you open an issue describing what would need doing and tag it as "good first issue"?

peterbell10 · 2023-05-07T22:57:47Z

@pytorchbot rebase

pytorchmergebot · 2023-05-07T22:59:50Z

@pytorchbot successfully started a rebase job. Check the current status here

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

pytorchmergebot · 2023-05-07T23:00:08Z

Successfully rebased gh/peterbell10/545/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/100464)

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: 762d30b Pull Request resolved: #100464

peterbell10 · 2023-05-07T23:32:00Z

@pytorchbot merge

pytorchmergebot · 2023-05-07T23:33:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ngimel

large/extreme values could have bugs in the implementation, libc++ might not handle those cases correctly (iirc we had to skip some mac tests for extreme values for the same reason)

pytorch-bot bot added the release notes: cuda release notes category label May 2, 2023

peterbell10 added a commit that referenced this pull request May 2, 2023

Fix AT_USE_JITERATOR checks

6fe5c6f

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: be1e006 Pull Request resolved: #100464

Fix AT_USE_JITERATOR checks

68a6aaa

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

pytorchbot added the open source label May 2, 2023

Update on "Fix AT_USE_JITERATOR checks"

4e92647

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

Update on "Fix AT_USE_JITERATOR checks"

016e6e4

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

peterbell10 added the topic: not user facing topic category label May 3, 2023

Update on "Fix AT_USE_JITERATOR checks"

5b1f066

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

peterbell10 added a commit that referenced this pull request May 3, 2023

Fix AT_USE_JITERATOR checks

1cb2e52

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: 8018036 Pull Request resolved: #100464

peterbell10 added the keep-going Don't stop on first failure, keep running tests until the end label May 3, 2023

peterbell10 added a commit that referenced this pull request May 3, 2023

Fix AT_USE_JITERATOR checks

4ff3bb7

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. ghstack-source-id: 09fade4 Pull Request resolved: #100464

Update on "Fix AT_USE_JITERATOR checks"

6c37706

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

peterbell10 marked this pull request as ready for review May 4, 2023 15:22

peterbell10 requested a review from lezcano May 5, 2023 21:57

peterbell10 commented May 5, 2023

View reviewed changes

lezcano approved these changes May 6, 2023

View reviewed changes

Update on "Fix AT_USE_JITERATOR checks"

065ee34

`AT_USE_JITERATOR` evaluates to false when the definition isn't included, so these files were not using jiterator at all. [ghstack-poisoned]

peterbell10 added the ciflow/trunk Trigger trunk jobs on your pull request label May 7, 2023

pytorchmergebot added the merging label May 7, 2023

ngimel approved these changes May 8, 2023

View reviewed changes

pytorchmergebot added Merged and removed merging labels May 8, 2023

pytorchmergebot closed this in 7d0e4e2 May 8, 2023

facebook-github-bot deleted the gh/peterbell10/545/head branch June 8, 2023 18:27

Uh oh!

Fix AT_USE_JITERATOR checks #100464

Fix AT_USE_JITERATOR checks #100464

Uh oh!

Conversation

peterbell10 commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100464

✅ No Failures

Uh oh!

peterbell10 May 5, 2023

Choose a reason for hiding this comment

Uh oh!

peterbell10 May 5, 2023

Choose a reason for hiding this comment

Uh oh!

lezcano May 6, 2023

Choose a reason for hiding this comment

Uh oh!

peterbell10 May 7, 2023

Choose a reason for hiding this comment

Uh oh!

lezcano left a comment

Choose a reason for hiding this comment

Uh oh!

lezcano May 6, 2023

Choose a reason for hiding this comment

Uh oh!

peterbell10 commented May 7, 2023

Uh oh!

pytorchmergebot commented May 7, 2023

Uh oh!

pytorchmergebot commented May 7, 2023

Uh oh!

peterbell10 commented May 7, 2023

Uh oh!

pytorchmergebot commented May 7, 2023

Merge started

Uh oh!

ngimel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

peterbell10 commented May 2, 2023 •

edited

Loading

pytorch-bot bot commented May 2, 2023 •

edited

Loading