Skip to content

Reland basic dynamo support for traceable collectives #100476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Reland basic dynamo support for traceable collectives #100476

wants to merge 4 commits into from

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented May 2, 2023 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Relative to the original land, this also contains:

  • Fix torchdeploy import of functional collectives
  • Can't import torchdynamo utils due to torch._refs being missing

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

@wconstab
Fix torchdeploy import of functional collectives
6cedfe4 
Can't import torchdynamo utils due to torch._refs being missing

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 2, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100476

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures

As of commit dd6d9d6:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kumpera
kumpera approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@kumpera kumpera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. Nice fix though.

@wconstab
Update on "Fix torchdeploy import of functional collectives"
c3fb403 
Can't import torchdynamo utils due to torch._refs being missing

[ghstack-poisoned]
wconstab added a commit that referenced this pull request May 2, 2023
@wconstab
Fix torchdeploy import of functional collectives
2ad7665 
Can't import torchdynamo utils due to torch._refs being missing

ghstack-source-id: 260472c
Pull Request resolved: #100476
@wconstab wconstab added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels May 2, 2023
@wconstab wconstab mentioned this pull request May 2, 2023
Closed
@wconstab
Update on "Fix torchdeploy import of functional collectives"
6dfb03d 
Can't import torchdynamo utils due to torch._refs being missing

[ghstack-poisoned]
@wconstab
Update on "Reland basic dynamo support for traceable collectives"
dd6d9d6 
Relative to the original land, this also contains:
- Fix torchdeploy import of functional collectives
- Can't import torchdynamo utils due to torch._refs being missing

[ghstack-poisoned]
@wconstab wconstab changed the title Fix torchdeploy import of functional collectives Reland basic dynamo support for traceable collectives May 3, 2023
wconstab added a commit that referenced this pull request May 3, 2023
@wconstab
Reland basic dynamo support for traceable collectives
8e1e613 
Relative to the original land, this also contains:
- Fix torchdeploy import of functional collectives
- Can't import torchdynamo utils due to torch._refs being missing

ghstack-source-id: 263490f
Pull Request resolved: #100476
@wconstab
Copy link
Contributor Author

wconstab commented May 3, 2023

@pytorchbot merge -ic

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: windows-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-build, windows-binary-libtorch-debug / libtorch-cpu-shared-with-deps-debug-build

Details for Dev Infra team Raised by workflow job

@wconstab
Copy link
Contributor Author

wconstab commented May 4, 2023

@pytorchbot merge -f"flaky infra"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wconstab/176/head branch June 8, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

1 more reviewer

@kumpera kumpera kumpera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wconstab @pytorchmergebot @kumpera