Skip to content

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented May 5, 2023

i think get_reordered_tests broken since master -> main switch

add typing for some functions

checked for prioritized in the logs

limited testing because I only care about one very small part of the log thats near the beginning

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 5, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented May 5, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100752

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 6a269d3:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 marked this pull request as ready for review May 5, 2023 21:50
@clee2000 clee2000 requested a review from a team as a code owner May 5, 2023 21:50
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Zain has a further tweak on #100748 but this is a simple fix, so it's unlikely to get conflicts I guess

@clee2000
Copy link
Contributor Author

clee2000 commented May 5, 2023

@pytorchbot merge -f "should be fine"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants