Skip to content

[inductor] default cache_dir in torch._inductor.codecache should be lazily evaluated #100824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[inductor] default cache_dir in torch._inductor.codecache should be lazily evaluated #100824

wants to merge 1 commit into from

Conversation

hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented May 7, 2023 •
edited by pytorch-bot bot
Loading

getpass.getuser may raise exceptions in some circumstances, where users cannot override the default cache dir with env TORCHINDUCTOR_CACHE_DIR. Hence the assemble of default cache dir should be lazily evaluated.

cc @soumith @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented May 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100824

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a508e25:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 7, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hsfzxjy (5b0d9fe0d5e2bb6628e473a1b01ba9611a5cdcf7)

@hsfzxjy hsfzxjy changed the title default cache_dir in torch._inductor.codecache should be lazily evaluated [inductor] default cache_dir in torch._inductor.codecache should be lazily evaluated May 8, 2023
@ezyang
Copy link
Contributor

ezyang commented May 10, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented May 10, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor topic: bug fixes topic category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hsfzxjy @ezyang @pytorchmergebot @pytorchbot