Skip to content

inductor(CPU): fix masked_fill issue when filled value is nan #101058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

inductor(CPU): fix masked_fill issue when filled value is nan #101058

wants to merge 2 commits into from

Conversation

XiaobingSuper
Copy link
Collaborator

@XiaobingSuper XiaobingSuper commented May 10, 2023 •
edited by pytorch-bot bot
Loading

@XiaobingSuper
inductor(CPU): fix masked_fill issue when filled value is nan
484b8c3 
[ghstack-poisoned]
@XiaobingSuper
Update on "inductor(CPU): fix masked_fill issue when filled value is …
b7cd306 
…nan"

cc soumith voznesenskym penguinwu EikanWang jgong5 Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101058

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit b7cd306:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XiaobingSuper XiaobingSuper linked an issue May 10, 2023 that may be closed by this pull request
[torch.compile] raises CppCompileError when pad with value NaN #100988
Closed
XiaobingSuper added a commit that referenced this pull request May 10, 2023
@XiaobingSuper
inductor(CPU): fix masked_fill issue when filled value is nan
434b9c4 
ghstack-source-id: b001dc0
Pull Request resolved: #101058
@XiaobingSuper XiaobingSuper requested a review from desertfire May 10, 2023 09:31
@XiaobingSuper
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-bionic-cuda11.8-py3.10-gcc7 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge)

Details for Dev Infra team Raised by workflow job

@XiaobingSuper
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/XiaobingSuper/113/head branch June 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@jgong5 jgong5 jgong5 approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[torch.compile] raises CppCompileError when pad with value NaN

5 participants

@XiaobingSuper @pytorchmergebot @desertfire @jgong5 @pytorchbot