[MPS] Dispatch outer bin edges selection function #101792
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101792
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 42866e1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
github-actions
bot
added
the
module: cpu
qqaatw
changed the title
Dispatch the selection function to prevent using `is_mps()` in `Histogram.cpp`. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
@kulinseth @malfet Could you review this stack? |
We already have opinfo for histc, histogram, and histogramdd, which should cover the change. |
Dispatch the selection function to prevent using `is_mps()` in `Histogram.cpp`. <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at b329a02</samp> This pull request refactors and implements the logic for inferring the bin edges of histograms from the input tensor for different device types. It introduces a dispatch stub `histogram_select_outer_bin_edges_stub` and moves the device-specific code to separate files, such as `HistogramKernel.cpp` and `HistogramKernel.mm`. This improves the modularity and readability of the histogram functions. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Dispatch the selection function to prevent using `is_mps()` in `Histogram.cpp`. <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at b329a02</samp> This pull request refactors and implements the logic for inferring the bin edges of histograms from the input tensor for different device types. It introduces a dispatch stub `histogram_select_outer_bin_edges_stub` and moves the device-specific code to separate files, such as `HistogramKernel.cpp` and `HistogramKernel.mm`. This improves the modularity and readability of the histogram functions. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
Gently pinging @malfet |
Dispatch the selection function to prevent using `is_mps()` in `Histogram.cpp`. <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at b329a02</samp> This pull request refactors and implements the logic for inferring the bin edges of histograms from the input tensor for different device types. It introduces a dispatch stub `histogram_select_outer_bin_edges_stub` and moves the device-specific code to separate files, such as `HistogramKernel.cpp` and `HistogramKernel.mm`. This improves the modularity and readability of the histogram functions. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
@malfet can you please take a look? the failing tests are from broken trunk I think. |
|
Hey @malfet, can you please review? |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Dispatch the selection function to prevent using `is_mps()` in `Histogram.cpp`. <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at b329a02</samp> This pull request refactors and implements the logic for inferring the bin edges of histograms from the input tensor for different device types. It introduces a dispatch stub `histogram_select_outer_bin_edges_stub` and moves the device-specific code to separate files, such as `HistogramKernel.cpp` and `HistogramKernel.mm`. This improves the modularity and readability of the histogram functions. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
Successfully rebased |
|
Ping @malfet for review, thanks! |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Dispatch the selection function to prevent using `is_mps()` in `Histogram.cpp`. <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at b329a02</samp> This pull request refactors and implements the logic for inferring the bin edges of histograms from the input tensor for different device types. It introduces a dispatch stub `histogram_select_outer_bin_edges_stub` and moves the device-specific code to separate files, such as `HistogramKernel.cpp` and `HistogramKernel.mm`. This improves the modularity and readability of the histogram functions. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
Successfully rebased |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Dispatch the selection function to prevent using
is_mps()inHistogram.cpp.🤖 Generated by Copilot at b329a02
This pull request refactors and implements the logic for inferring the bin edges of histograms from the input tensor for different device types. It introduces a dispatch stub
histogram_select_outer_bin_edges_stuband moves the device-specific code to separate files, such asHistogramKernel.cppandHistogramKernel.mm. This improves the modularity and readability of the histogram functions.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10