Skip to content

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented May 18, 2023

Stack from ghstack:

Tests that a custom op annotated with Sequence[int] actually accepts
Sequence[SymInt].

Tests that a custom op annotated with Sequence[int] actually accepts
Sequence[SymInt].

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101822

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 769e100:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider doing an assertExpectedInline on the traced graph

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit only

zou3519 added 2 commits May 22, 2023 11:56
Tests that a custom op annotated with Sequence[int] actually accepts
Sequence[SymInt].

[ghstack-poisoned]
Tests that a custom op annotated with Sequence[int] actually accepts
Sequence[SymInt].

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/661/head branch June 8, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants