nomnigraph - Enhancements to subgraph matching APIs #10218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#10218 SubtreeMatchCriteria now supports: - nonTerminal flag : if this is set, it means we only match the root of the subtree and do not care about the children. Example use case: to match an "input" node but does not care how the input is produced. Additional tests for these new logic are added to subgraph_matcher_test.cc. Subgraph matching APIs for NNGraph is also added. (Further enhancement to make the SubgraphMatching API constructs a Subgraph object/more diagnostic information will go later). Differential Revision: D9156092 fbshipit-source-id: 069f10015fa51e9a03feff75d1501c3a0210fcd8
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: Pull Request resolved: pytorch#10218 SubtreeMatchCriteria now supports: - nonTerminal flag : if this is set, it means we only match the root of the subtree and do not care about the children. Example use case: to match an "input" node but does not care how the input is produced. Additional tests for these new logic are added to subgraph_matcher_test.cc. Subgraph matching APIs for NNGraph is also added. (Further enhancement to make the SubgraphMatching API constructs a Subgraph object/more diagnostic information will go later). Reviewed By: bwasti Differential Revision: D9156092 fbshipit-source-id: 3f28ac15d9edd474b3e0cd51fd7e6f973299d061
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10218 SubtreeMatchCriteria now supports: - nonTerminal flag : if this is set, it means we only match the root of the subtree and do not care about the children. Example use case: to match an "input" node but does not care how the input is produced. Additional tests for these new logic are added to subgraph_matcher_test.cc. Subgraph matching APIs for NNGraph is also added. (Further enhancement to make the SubgraphMatching API constructs a Subgraph object/more diagnostic information will go later). Reviewed By: bwasti Differential Revision: D9156092 fbshipit-source-id: 3f28ac15d9edd474b3e0cd51fd7e6f973299d061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SubtreeMatchCriteria now supports these additional requirements:
Additional tests for these new logic are added to subgraph_matcher_test.cc.
Subgraph matching APIs for NNGraph is also added.
(Further enhancement to make the SubgraphMatching API constructs a Subgraph object/more diagnostic information will go later).
Differential Revision: D9156092