Make TestPythonRegistration clean up after itself #102292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did this for TestCustomOp, now we are applying the same thing to TestPythonRegistration. This PR: - changes TestPythonRegistration to register new ops under a single namespace (self.test_ns) - clean up the namespace by deleting it from torch.ops after each test is done running. This avoids a problem where if an op is re-defined, torch.ops.myns.op crashes because we do some caching. The workaround in many of these tests have been to just create an op with a different name, but this PR makes it so that we don't need to do this. Test Plan: - existing tests [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102292
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ce3b64a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
May 27, 2023
ezyang
reviewed
May 27, 2023
bdhirsh
approved these changes
May 31, 2023
We did this for TestCustomOp, now we are applying the same thing to TestPythonRegistration. This PR: - changes TestPythonRegistration to register new ops under a single namespace (self.test_ns) - clean up the namespace by deleting it from torch.ops after each test is done running. This avoids a problem where if an op is re-defined, torch.ops.myns.op crashes because we do some caching. The workaround in many of these tests have been to just create an op with a different name, but this PR makes it so that we don't need to do this. Test Plan: - existing tests [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We did this for TestCustomOp, now we are applying the same thing to
TestPythonRegistration.
This PR:
namespace (self.test_ns)
is done running.
This avoids a problem where if an op is re-defined, torch.ops.myns.op
crashes because we do some caching. The workaround in many of these
tests have been to just create an op with a different name, but this PR
makes it so that we don't need to do this.
Test Plan: