Skip to content

[Dynamo] Save global autocast state to restore on graph break #102415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Dynamo] Save global autocast state to restore on graph break #102415

wants to merge 3 commits into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented May 26, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented May 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102415

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bdaa1c8:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added the topic: not user facing topic category label May 26, 2023
@yanboliang yanboliang requested review from anijain2305 and yf225 May 26, 2023 23:03
yf225
yf225 reviewed May 27, 2023
View reviewed changes
@anijain2305
Copy link
Contributor

There is also a autocast_cache_enabled thing. I am not sure what is it used for, but maybe we need to save-restore that well. cc @eellison

@yanboliang
Copy link
Contributor Author

There is also a autocast_cache_enabled thing. I am not sure what is it used for, but maybe we need to save-restore that well.

Added

yf225
yf225 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yanbo!

@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label May 30, 2023
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the auto branch May 30, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yf225 yf225 yf225 approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dynamo] graph break under autocast context manager inlining failure caused NE gap

4 participants

@yanboliang @anijain2305 @pytorchmergebot @yf225