Skip to content

[benchmark] Flag to switch on activation checkpointing for HF models #102557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[benchmark] Flag to switch on activation checkpointing for HF models #102557

wants to merge 2 commits into from

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented May 30, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented May 30, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102557

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e095d2c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced May 30, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@anijain2305 anijain2305 requested a review from jansel May 30, 2023 18:24
@anijain2305
Update on "[benchmark] Flag to switch on activation checkpointing for…
e095d2c 
… HF models"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 30, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@anijain2305 anijain2305 added the topic: not user facing topic category label May 30, 2023
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anijain2305 anijain2305 mentioned this pull request May 30, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/anijain2305/46/head branch June 8, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

@ngimel ngimel ngimel approved these changes

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anijain2305 @pytorchmergebot @Chillee @ngimel