Add a new UNSTABLE category in trymerge #102784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
added
ciflow/trunk
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102784
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 62277eb: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
approved these changes
Jun 1, 2023
huydhn
added a commit
to pytorch/test-infra
that referenced
this pull request
Jun 2, 2023
After pytorch/pytorch#102426 and pytorch/pytorch#102784 landed, unstable jobs are now hidden correctly on HUD https://hud.pytorch.org and also won't block PR. Previously, this was done by moving unstable jobs to an unstable workflow. Now unstable jobs will stay in the same workflow, but have `unstable` in their names. This is very similar to how `rerun_disabled_tests` are ignored atm. ### Testing https://torchci-git-fork-huydhn-ignore-unstable-jobs-fbopensource.vercel.app/metrics
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
PaliC
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Jun 5, 2023
After pytorch/pytorch#102426 and pytorch/pytorch#102784 landed, unstable jobs are now hidden correctly on HUD https://hud.pytorch.org and also won't block PR. Previously, this was done by moving unstable jobs to an unstable workflow. Now unstable jobs will stay in the same workflow, but have `unstable` in their names. This is very similar to how `rerun_disabled_tests` are ignored atm. ### Testing https://torchci-git-fork-huydhn-ignore-unstable-jobs-fbopensource.vercel.app/metrics
huydhn
added a commit
to pytorch/test-infra
that referenced
this pull request
Jun 7, 2023
Per title, we want to hide unstable jobs in a collapsible section like flaky and broken trunk. I opt for an unstable section for clarity but we could also add unstable jobs into flaky section (to reuse the name). Note that unstable job failures doesn't block merge pytorch/pytorch#102784
malfet
reviewed
Jun 28, 2023
| self.assertTrue(len(failed) == 2) | ||
|
|
||
| def test_get_classifications_unstable(self, *args: Any) -> None: | ||
| pr = GitHubPR("pytorch", "pytorch", 102784) |
There was a problem hiding this comment.
We should never self-reference mocks, as when PR is landed checks might be different... (this is what I'm experiencing right now when trying to regenerate mocks)
malfet
added a commit
that referenced
this pull request
Jun 28, 2023
- Add `ngimel` to the list of reviewers to make "test_revert_rules" pass - Change PR in `test_get_classifications_unstable` from #102784 to #104312 as former do not have unstable jobs after merging. <!-- copilot:poem --> ### <samp>🤖 Generated by Copilot at af26e18</samp> > _Oh we're the crew of the `test_trymerge.py`_ > _We update the rules and the cases on the fly_ > _We heave and we haul on the count of three_ > _We add a new approver for the `super` rule, aye_ cc albanD [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 28, 2023
- Add `ngimel` to the list of reviewers to make "test_revert_rules" pass - Change PR in `test_get_classifications_unstable` from #102784 to #104312 as former do not have unstable jobs after merging. <!-- copilot:poem --> ### <samp>🤖 Generated by Copilot at af26e18</samp> > _Oh we're the crew of the `test_trymerge.py`_ > _We update the rules and the cases on the fly_ > _We heave and we haul on the count of three_ > _We add a new approver for the `super` rule, aye_ Pull Request resolved: #104343 Approved by: https://github.com/jeanschmidt, https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, after #102426 landed, it makes sense to have a new category for UNSTABLE jobs and handle them accordingly in trymerge.
unstablein the check (job) name. I plan to roll this out first and then see if we need to cover the more complicated, but less popular case, of unstable build job. Specifically, an unstable build job has nounstablein its nameTesting
Leverage the broken trunk Windows CPU job atm and mark Windows CPU jobs as unstable #102297