[quant][pt2] Add prepare QAT test for resnet18 #103020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

andrewor14 wants to merge 1 commit into pytorch:main from andrewor14:export-D46456243

Contributor

andrewor14 commented Jun 5, 2023

Summary:
Prepare QAT for resnet18 has matching numerics with FX.
Adding this test requires us to refactor the way the test code
is structured, however.

Test Plan: python test/test_quantization.py TestQuantizePT2EModels.test_qat_resnet18

Differential Revision: D46456243

andrewor14 requested a review from jerryzh168 as a code owner

June 5, 2023 20:52

pytorch-bot bot commented Jun 5, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103020

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5ce5c0f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the topic: not user facing label

github-actions bot added the release notes: quantization label

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from a487f59 to b5d1ef0 Compare

June 5, 2023 21:09

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from b5d1ef0 to 3202067 Compare

June 6, 2023 15:13

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from 3202067 to 6bef00c Compare

June 6, 2023 15:22

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from 6bef00c to b7651e4 Compare

June 6, 2023 15:31

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from b7651e4 to b03755b Compare

June 6, 2023 15:40

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from b03755b to 3410d29 Compare

June 6, 2023 21:21

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from 3410d29 to 0b5f448 Compare

June 6, 2023 21:31

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

kimishpatel approved these changes

View reviewed changes

kimishpatel approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Jun 7, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

andrewor14 force-pushed the export-D46456243 branch from 0b5f448 to 05a5efb Compare

June 7, 2023 21:41


          [quant][pt2] Add prepare QAT test for resnet18 (pytorch#103020)

5ce5c0f

Summary:
Pull Request resolved: pytorch#103020

Prepare QAT for resnet18 has matching numerics with FX.
Adding this test requires us to refactor the way the test code
is structured, however.

Test Plan: python test/test_quantization.py TestQuantizePT2EModels.test_qat_resnet18

Reviewed By: kimishpatel, jerryzh168

Differential Revision: D46456243

fbshipit-source-id: 9735f9d32b1bf8940b8bc5014e9eb41dcc232fa6

andrewor14 force-pushed the export-D46456243 branch from 05a5efb to 5ce5c0f Compare

June 7, 2023 21:50

Contributor

facebook-github-bot commented Jun 7, 2023

This pull request was exported from Phabricator. Differential Revision: D46456243

Contributor

facebook-github-bot commented Jun 8, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jun 8, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

9508e60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged release notes: quantization topic: not user facing