[PT2][Quant] Use composble quantizer for embedding + static conv + dynamic #103116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namic Summary: In this diff we test a module that does a) emedding lookup b) runs 1D (converted to 2D) conv and c) runs linear on the output of 1d conv. a is quantized using embedding quantizer. c is quantized using dynamic quantization. b is quantized using static quantization. We compose quantizer from [a, c, b]. Tested it against similar fx config. Test Plan: test_embedding_conv_linear_quantization Reviewed By: jerryzh168 Differential Revision: D46267688 fbshipit-source-id: 4adf3021cf8e2a7a22788eda3d731356e7851356
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103116
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit afe7d50: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D46267688 |
jerryzh168
approved these changes
Jun 7, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
added
the
ciflow/unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff we test a module that does a) emedding lookup b) runs 1D
(converted to 2D) conv and c) runs linear on the output of 1d conv.
a is quantized using embedding quantizer.
c is quantized using dynamic quantization.
b is quantized using static quantization.
We compose quantizer from [a, c, b]. Tested it against similar fx config.
Test Plan: test_embedding_conv_linear_quantization
Reviewed By: jerryzh168
Differential Revision: D46267688