Remove hack as integrated builds use FULL_CAFFE2 now #10320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
pjh5
approved these changes
Aug 7, 2018
|
Dammit, it doesn't work. |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot retest this please |
pjh5
approved these changes
Aug 7, 2018
| make "-j${MAX_JOBS}" install | ||
| else | ||
| echo "Don't know how to build on $(uname)" | ||
| exit 1 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| sudo FULL_CAFFE2=1 python setup.py install | ||
| # TODO: I'm not sure why this is necessary | ||
| cp -r torch/lib/tmp_install $INSTALL_PREFIX |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| echo "Don't know how to build on $(uname)" | ||
| exit 1 | ||
| sudo FULL_CAFFE2=1 python setup.py install |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#10320 Reviewed By: jerryzh168 Differential Revision: D9198902 Pulled By: ezyang fbshipit-source-id: 8af28d607735e5f4450c40127c1f8c262ea602ce
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#10320 Reviewed By: jerryzh168 Differential Revision: D9198902 Pulled By: ezyang fbshipit-source-id: 8af28d607735e5f4450c40127c1f8c262ea602ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang ezyang@fb.com