Skip to content

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented Jun 9, 2023

Stack from ghstack (oldest at bottom):

This lets users run TORCH_LOGS="+distributed" python myscript.py and enable additional logging output for the distributed module.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103287

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6736c68:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Copy link
Contributor

ezyang commented Jun 9, 2023

This doesn't seem right. Why is distributed an artifact logger? I would expect it to be a regular logger rooted at torch.distributed

@ezyang ezyang requested a review from mlazos June 9, 2023 14:50
This lets users run `TORCH_LOGS="+distributed" python myscript.py` and enable additional logging output for the distributed module. 


[ghstack-poisoned]
@wconstab
Copy link
Contributor Author

wconstab commented Jun 9, 2023

good catch. i copypasted the wrong thing :( this looks better, i confirmed it works, but please double check in case something is subtly wrong (also next PR) @ezyang

@wconstab wconstab added the topic: not user facing topic category label Jun 9, 2023
@wconstab
Copy link
Contributor Author

wconstab commented Jun 9, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Contributor

@pytorchbot revert -m "Breaks trunk" -c landrace

See https://hud.pytorch.org/pytorch/pytorch/commit/0b252aebb2e46c0dc5585ec6d296832a308f563b for details

It's a weird failure, but looks like test is expecting the log to behave differently

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@wconstab your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jun 9, 2023
This reverts commit 0b252ae.

Reverted #103287 on behalf of https://github.com/ZainRizvi due to Breaks trunk ([comment](#103287 (comment)))
@facebook-github-bot facebook-github-bot deleted the gh/wconstab/195/head branch June 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants