-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add distributed category to TORCH_LOGS #103287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103287
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6736c68: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This doesn't seem right. Why is distributed an artifact logger? I would expect it to be a regular logger rooted at torch.distributed |
This lets users run `TORCH_LOGS="+distributed" python myscript.py` and enable additional logging output for the distributed module. [ghstack-poisoned]
good catch. i copypasted the wrong thing :( this looks better, i confirmed it works, but please double check in case something is subtly wrong (also next PR) @ezyang |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "Breaks trunk" -c landrace See https://hud.pytorch.org/pytorch/pytorch/commit/0b252aebb2e46c0dc5585ec6d296832a308f563b for details It's a weird failure, but looks like test is expecting the log to behave differently |
@pytorchbot successfully started a revert job. Check the current status here. |
@wconstab your PR has been successfully reverted. |
This reverts commit 0b252ae. Reverted #103287 on behalf of https://github.com/ZainRizvi due to Breaks trunk ([comment](#103287 (comment)))
Stack from ghstack (oldest at bottom):
This lets users run
TORCH_LOGS="+distributed" python myscript.py
and enable additional logging output for the distributed module.