Skip to content

Conversation

CaoE
Copy link
Collaborator

@CaoE CaoE commented Jun 9, 2023

Add Half support for addcmul, addcdiv, cumsum, and topk on CPU.
Note: This PR will introduce the issue #111454.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103319

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8ec9fef with merge base 18cc8a9 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jun 9, 2023
@CaoE CaoE changed the title Add Half support for addcmul and addcdiv on CPU Add Half support for addcmul, addcdiv, and cumsum on CPU Jun 9, 2023
@CaoE CaoE changed the title Add Half support for addcmul, addcdiv, and cumsum on CPU Add Half support for addcmul, addcdiv, cumsum, and topk on CPU Jun 12, 2023
@CaoE CaoE added the topic: not user facing topic category label Jun 12, 2023
@CaoE CaoE force-pushed the fp16_addcmul branch 2 times, most recently from ad03513 to c7263ff Compare June 20, 2023 06:23
@CaoE CaoE requested review from jgong5 and mingfeima June 20, 2023 13:26
@CaoE CaoE marked this pull request as ready for review June 21, 2023 06:08
@CaoE CaoE requested review from mruberry and ngimel as code owners June 21, 2023 06:08
CaoE added a commit that referenced this pull request Jul 4, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 4, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 11, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 11, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 12, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 12, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 12, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 16, 2023
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 16, 2023
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@CaoE CaoE requested a review from kulinseth as a code owner October 17, 2023 05:00
@CaoE CaoE force-pushed the fp16_addcmul branch 2 times, most recently from a3155a7 to c776d7d Compare October 18, 2023 05:50
@CaoE CaoE requested a review from cpuhrsch October 19, 2023 06:26
@CaoE
Copy link
Collaborator Author

CaoE commented Oct 19, 2023

@cpuhrsch Could you please review this PR ? Thank you.

@cpuhrsch
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
…ch#103319)

Add Half support for addcmul, addcdiv, cumsum, and topk on CPU.
Note: This PR will introduce the issue  pytorch#111454.

Pull Request resolved: pytorch#103319
Approved by: https://github.com/jgong5, https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants