Skip to content

[dynamo][numpy] Add support for builtin functions #103457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[dynamo][numpy] Add support for builtin functions #103457

wants to merge 3 commits into from

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Jun 12, 2023 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

In order to be able to run stuff like:

def f(x):
	a = x.numpy()
        return a + a

This PR adds a branch in BuiltinVariable to handle NumpyNdarrayVariable case.

cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @msaroufim

@larryliu0820
[dynamo][numpy] Add support for builtin functions
b06cfe3 
In order to be able to run stuff like:
```
def f(x):
	a = x.numpy()
        return a + a
```
This PR adds a branch in `BuiltinVariable` to handle `NumpyNdarrayVariable` case.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 12, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103457

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e56132b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

larryliu0820 added a commit that referenced this pull request Jun 12, 2023
@larryliu0820
[dynamo][numpy] Add support for builtin functions
40222a5 
In order to be able to run stuff like:
```
def f(x):
	a = x.numpy()
        return a + a
```
This PR adds a branch in `BuiltinVariable` to handle `NumpyNdarrayVariable` case.

ghstack-source-id: 3002513
Pull Request resolved: #103457
@larryliu0820 larryliu0820 requested a review from ezyang June 12, 2023 20:44
@larryliu0820 larryliu0820 added the topic: not user facing topic category label Jun 12, 2023
@ezyang
Copy link
Contributor

ezyang commented Jun 13, 2023

Guessing this is not ready for review yet?

@larryliu0820
Copy link
Contributor Author

Yeah let me fix the failures

@larryliu0820
Update on "[dynamo][numpy] Add support for builtin functions"
264bb9e 
In order to be able to run stuff like:
```
def f(x):
	a = x.numpy()
        return a + a
```
This PR adds a branch in `BuiltinVariable` to handle `NumpyNdarrayVariable` case.

cc voznesenskym penguinwu anijain2305 @EikanWang jgong5 @Guobing-Chen @XiaobingSuper zhuhaozhe blzheng @Xia-Weiwen wenzhe-nrv jiayisunx ipiszy

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jun 13, 2023
@larryliu0820
[dynamo][numpy] Add support for builtin functions
330955f 
In order to be able to run stuff like:
```
def f(x):
	a = x.numpy()
        return a + a
```
This PR adds a branch in `BuiltinVariable` to handle `NumpyNdarrayVariable` case.

ghstack-source-id: 46ba8f4
Pull Request resolved: #103457
@larryliu0820
Copy link
Contributor Author

@ezyang seems ready - I'm not sure if this is the right implementation though

@larryliu0820 larryliu0820 mentioned this pull request Jun 14, 2023
Closed
ezyang
ezyang reviewed Jun 14, 2023
View reviewed changes
ezyang
ezyang approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. It probably doesn't handle all the edges correctly but let's put it in for now.

@larryliu0820
Update on "[dynamo][numpy] Add support for builtin functions"
e56132b 
In order to be able to run stuff like:
```
def f(x):
	a = x.numpy()
        return a + a
```
This PR adds a branch in `BuiltinVariable` to handle `NumpyNdarrayVariable` case.

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jun 15, 2023
@larryliu0820
[dynamo][numpy] Add support for builtin functions
5b1fe70 
In order to be able to run stuff like:
```
def f(x):
	a = x.numpy()
        return a + a
```
This PR adds a branch in `BuiltinVariable` to handle `NumpyNdarrayVariable` case.

ghstack-source-id: 56f29f3
Pull Request resolved: #103457
@larryliu0820
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.4.2-py3.8 / test (default, 3, 3, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@larryliu0820
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/larryliu0820/34/head branch June 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larryliu0820 @ezyang @pytorchmergebot