Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 21, 2023

Comment about TEST_CUDNN called over and over has long been alleviated by wrapping the check with LazyVal, that caches the results.
Also, delete unused TEST_MAGMA.

Prep change for #100006

🤖 Generated by Copilot at e3a5b39

common_cuda.py
Refactored for dynamo tests
Winter code cleanup

cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103982

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 072adf4:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested a review from a team June 21, 2023 18:56
@malfet malfet added topic: not user facing topic category ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jun 21, 2023
@malfet
Copy link
Contributor Author

malfet commented Jun 21, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Comment about `TEST_CUDNN` called over and over has long been alliviated by wrapping the check with `LazyVal`, that caches the results.
Also, delete unused `TEST_MAGMA`
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet malfet force-pushed the malfet/be-use-cuda-common-utils branch from e3a5b39 to 072adf4 Compare June 21, 2023 23:01
@malfet
Copy link
Contributor Author

malfet commented Jun 22, 2023

@pytorchbot merge -f "This is just a lint fix, previous variant were green all but lint: https://hud.pytorch.org/pytorch/pytorch/commit/e3a5b393ca060a8eb65fc5b09f22ad66525bf2ad "

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet/be-use-cuda-common-utils branch June 24, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants