Skip to content

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Jun 30, 2023

Ignore config fusion limit for foreach nodes since they have their own fusion limits which will be split automatically. With the fusion limit this will automatically start not fusing epilogue copies if there are more than 64 tensors in the foreach lists (very bad) which will create a ton of extra allocations. With this change, fusions with the subkernels still respect this limit.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78

@mlazos mlazos requested a review from jansel June 30, 2023 17:38
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104471

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit cda59c2:

NEW FAILURE - The following job has failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos changed the title Don't limit fusions with foreach scheduler noes Don't limit fusions with foreach scheduler nodes Jun 30, 2023
@mlazos mlazos added ciflow/trunk Trigger trunk jobs on your pull request release notes: inductor labels Jun 30, 2023
@mlazos
Copy link
Contributor Author

mlazos commented Jun 30, 2023

@pytorchbot merge -f 'Unrelated failures'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the mlazos/fuse-fix branch December 30, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants