Skip to content

correct the generated code and corresponding text to make them consistent #104596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

correct the generated code and corresponding text to make them consistent #104596

wants to merge 2 commits into from

Conversation

x1on9f31
Copy link
Contributor

@x1on9f31 x1on9f31 commented Jul 4, 2023

Fixes #104500

As discussed in #104500, the corresponding doc for dynamo is inconsistent between the code and explanation. I have run the code example to get the correct code.
image
This PR fixes the problem and makes the doc more readable.

cc:
@davidberard98 @ezyang please help me check this PR, thanks!

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104596

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 03a2126:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 4, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ezyang
Copy link
Contributor

ezyang commented Jul 4, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 4, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@x1on9f31
Copy link
Contributor Author

x1on9f31 commented Jul 4, 2023

@ezyang Could you please help merge this version? Previous version did not pass the linter test and I have fixed it. Sorry for the inconvenience.

@ezyang
Copy link
Contributor

ezyang commented Jul 4, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: inductor topic: docs topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Example Code and Explanation in TorchDynamo Documentation

3 participants

@x1on9f31 @ezyang @pytorchmergebot