Skip to content

Conversation

alexsamardzic
Copy link
Collaborator

@alexsamardzic alexsamardzic commented Jul 4, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104608

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 58206bc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Jul 4, 2023
alexsamardzic added a commit that referenced this pull request Jul 4, 2023
ghstack-source-id: 379592d
Pull Request resolved: #104608
@alexsamardzic alexsamardzic added module: sparse Related to torch.sparse topic: not user facing topic category open source and removed release notes: sparse release notes category labels Jul 5, 2023
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
@alexsamardzic
Copy link
Collaborator Author

Just removed the code doing dense->(sparse,meta) conversion, thus sparse semi-structured linear operator simplified (renamed, for consistency, too).

alexsamardzic added a commit that referenced this pull request Jul 5, 2023
ghstack-source-id: 8129f2a
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 5, 2023
ghstack-source-id: 0f87cf5
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 6, 2023
ghstack-source-id: 64542b7
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 6, 2023
ghstack-source-id: 21c50a1
Pull Request resolved: #104608
alexsamardzic added a commit that referenced this pull request Jul 6, 2023
ghstack-source-id: 21c50a1
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 6, 2023
ghstack-source-id: ce61dc5
Pull Request resolved: #104608
alexsamardzic added a commit that referenced this pull request Jul 10, 2023
ghstack-source-id: ce61dc5
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 10, 2023
ghstack-source-id: f5f44ed
Pull Request resolved: #104608
alexsamardzic added a commit that referenced this pull request Jul 11, 2023
ghstack-source-id: f5f44ed
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 11, 2023
ghstack-source-id: f630517
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 11, 2023
ghstack-source-id: cff55ce
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
>>> torch.allclose(c, torch.mm(a_sparse, b))
True

Under the hood, SparseSemiStructuredTensor will call ``torch._structured_sparse_linear`` for accelerated inference using CUTLASS sparse kernels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this entirely. We don't document private functions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See small comments, otherwise this is fine.

alexsamardzic added a commit that referenced this pull request Jul 13, 2023
ghstack-source-id: 0f3a2b6
Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer

[ghstack-poisoned]
alexsamardzic added a commit that referenced this pull request Jul 13, 2023
ghstack-source-id: c3eb18f
Pull Request resolved: #104608
@alexsamardzic
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/alexsamardzic/16/head branch July 17, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants