-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Update sparse semi-structured linear operator #104608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104608
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 58206bc: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
Just removed the code doing dense->(sparse,meta) conversion, thus sparse semi-structured linear operator simplified (renamed, for consistency, too). |
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
>>> torch.allclose(c, torch.mm(a_sparse, b)) | ||
True | ||
|
||
Under the hood, SparseSemiStructuredTensor will call ``torch._structured_sparse_linear`` for accelerated inference using CUTLASS sparse kernels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this entirely. We don't document private functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See small comments, otherwise this is fine.
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @nikitaved @pearu @cpuhrsch @amjames @bhosmer