Skip to content

Expose some APIs in FunctionsManual.h #104684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expose some APIs in FunctionsManual.h #104684

wants to merge 1 commit into from

Conversation

Bin1024
Copy link
Contributor

@Bin1024 Bin1024 commented Jul 6, 2023

Fixes #ISSUE_NUMBER
Exporse some api in FunctionsManual.h for custom devices. This can be used in codegen features.

@Bin1024 Bin1024 requested review from albanD and soulitzer as code owners July 6, 2023 02:18
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104684

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7c29243:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Bin1024 Bin1024 force-pushed the expose_torch_api branch from f67fa9b to 21db830 Compare July 6, 2023 04:36
@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 6, 2023

Hi @albanD . Sorry to bother you. Please review this PR for a moment.

albanD
albanD approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@soulitzer soulitzer changed the title expose funcionsmanual api Expose some APIs in FunctionsManual.h Jul 6, 2023
@soulitzer soulitzer removed their request for review July 6, 2023 18:23
@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 7, 2023
@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-test / test

Details for Dev Infra team Raised by workflow job

@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased expose_torch_api onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout expose_torch_api && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023

@pytorchbot merge -i
These look very much unrelated.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-test / test, trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023 •
edited
Loading

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased expose_torch_api onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout expose_torch_api && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda12_1-with-pypi-cudnn-test / test

Details for Dev Infra team Raised by workflow job

@Bin1024 Bin1024 force-pushed the expose_torch_api branch 2 times, most recently from ad5fb2d to 7c29243 Compare July 7, 2023 07:55
@Bin1024
Copy link
Contributor Author

Bin1024 commented Jul 7, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bin1024 @pytorchmergebot @albanD