[device_mesh][BE] reduce_scatter fallback to funcol and remove from DM #105642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DM For the reason similar to #105605 [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105642
Note: Links to docs will display an error until the docs builds have been completed. ✅ 2 Unrelated FailuresAs of commit cbd7326: UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 20, 2023
…move from DM" For the reason similar to #105605 [ghstack-poisoned]
wanchaol
changed the title
…move from DM" For the reason similar to #105605 [ghstack-poisoned]
wanchaol
added
ciflow/trunk
kumpera
approved these changes
Jul 26, 2023
| output = mesh.reduce_scatter( | ||
| tensor, op=reduce_op, mesh_dim=mesh_dim, scatter_dim=self.dim | ||
| output = funcol.reduce_scatter_tensor( | ||
| tensor, reduce_op.name, scatter_dim=self.dim, group=(mesh, mesh_dim) |
There was a problem hiding this comment.
Should we support reduce_op directly as well in the python wrappers of funcol?
There was a problem hiding this comment.
yeah that's a good point.. I can give it a try in a follow up PR
fduwjj
approved these changes
Jul 26, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For the reason similar to #105605