Skip to content

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jul 21, 2023

Stack from ghstack (oldest at bottom):

As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105769

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 98cfb02:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BowenBao
Copy link
Collaborator Author

Ok, forgot about the ORT in CI still segfaults running var_mean.

@titaiwangms
Copy link
Collaborator

Ok, forgot about the ORT in CI still segfaults running var_mean.

Should we ban the ops leading to SegFault?

As title, add test for ops already supported.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jul 24, 2023
ghstack-source-id: 9ef8ebe
Pull Request resolved: #105769
@BowenBao BowenBao added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2023
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. batch norm tests are enabled because of the onnxscript bump, not because of the fake mode PR on this ghstack, right?

@BowenBao
Copy link
Collaborator Author

@thiagocrepaldi correct.

Yesterday updated CI ORT to 1.15.1. Yet segfault happens in onnx shape inference, so need to bump CI onnx to onnx-weekly, and may need onnx inliner.
#105618 does that, so this PR can wait for that.

As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jul 24, 2023
ghstack-source-id: d8b7344
Pull Request resolved: #105769
As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jul 24, 2023
ghstack-source-id: 728403a
Pull Request resolved: #105769
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen this CI failure?

(...)
  File "onnx/test_fx_op_consistency.py", line 689 in <module>
FINISHED PRINTING LOG FILE of onnx/test_fx_op_consistency 1/2 (/var/lib/jenkins/workspace/test/test-reports/onnx-test_fx_op_consistency_p5m8cggy.log)

onnx/test_fx_op_consistency 1/2 failed! Received signal: SIGSEGV
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/run_test.py", line 1681, in <module>
    main()
  File "/var/lib/jenkins/workspace/test/run_test.py", line 1650, in main
    failure_messages = run_tests(
  File "/var/lib/jenkins/workspace/test/run_test.py", line 1559, in run_tests
    raise RuntimeError(
RuntimeError: onnx/test_fx_op_consistency 1/2 failed! Received signal: SIGSEGV

@BowenBao
Copy link
Collaborator Author

@pytorchbot rebase

@BowenBao
Copy link
Collaborator Author

Have you seen this CI failure?

#105769 (comment)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/271/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/105769)

pytorchmergebot pushed a commit that referenced this pull request Jul 25, 2023
ghstack-source-id: 09ead00
Pull Request resolved: #105769
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@BowenBao
Copy link
Collaborator Author

BowenBao commented Aug 8, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/271/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/105769)

pytorchmergebot pushed a commit that referenced this pull request Aug 8, 2023
ghstack-source-id: 6c0db67
Pull Request resolved: #105769
@BowenBao
Copy link
Collaborator Author

BowenBao commented Aug 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/271/head branch August 12, 2023 14:16
Cyril-Anto pushed a commit to Cyril-Anto/pytorch that referenced this pull request Aug 17, 2023
As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.
Pull Request resolved: pytorch#105769
Approved by: https://github.com/titaiwangms, https://github.com/thiagocrepaldi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants