-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ONNX] Turn on batch norm related unittest #105769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105769
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit 98cfb02: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Ok, forgot about the ORT in CI still segfaults running |
Should we ban the ops leading to SegFault? |
As title, add test for ops already supported. [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. batch norm tests are enabled because of the onnxscript bump, not because of the fake mode PR on this ghstack, right?
@thiagocrepaldi correct. Yesterday updated CI ORT to 1.15.1. Yet segfault happens in onnx shape inference, so need to bump CI onnx to onnx-weekly, and may need onnx inliner. |
As title, add test for ops already supported. Bump ORT in CI to 1.15.1 release version. [ghstack-poisoned]
As title, add test for ops already supported. Bump ORT in CI to 1.15.1 release version. [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen this CI failure?
(...)
File "onnx/test_fx_op_consistency.py", line 689 in <module>
FINISHED PRINTING LOG FILE of onnx/test_fx_op_consistency 1/2 (/var/lib/jenkins/workspace/test/test-reports/onnx-test_fx_op_consistency_p5m8cggy.log)
onnx/test_fx_op_consistency 1/2 failed! Received signal: SIGSEGV
Traceback (most recent call last):
File "/var/lib/jenkins/workspace/test/run_test.py", line 1681, in <module>
main()
File "/var/lib/jenkins/workspace/test/run_test.py", line 1650, in main
failure_messages = run_tests(
File "/var/lib/jenkins/workspace/test/run_test.py", line 1559, in run_tests
raise RuntimeError(
RuntimeError: onnx/test_fx_op_consistency 1/2 failed! Received signal: SIGSEGV
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
As title, add test for ops already supported. Bump ORT in CI to 1.15.1 release version. [ghstack-poisoned]
Successfully rebased |
@pytorchbot merge |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
As title, add test for ops already supported. Bump ORT in CI to 1.15.1 release version. [ghstack-poisoned]
Successfully rebased |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As title, add test for ops already supported. Bump ORT in CI to 1.15.1 release version. Pull Request resolved: pytorch#105769 Approved by: https://github.com/titaiwangms, https://github.com/thiagocrepaldi
Stack from ghstack (oldest at bottom):
As title, add test for ops already supported.
Bump ORT in CI to 1.15.1 release version.