Add details about ic, broken, flaky, and unstable checks to merge records

[huydhn]

At the moment, we only record the list of pending and failed check on Rockset merge records. This is enough to compute the force merge KPI(s), but isn't enough for more in-depth analysis on what happened at the time of the merge:

• If the number of ok_failed_checks is less than ok_failed_checks_threshold, the list of failed_checks would be empty (expectedly). So Rockset would only record an empty list.
• We support retry in PR, so the classifications on Dr.CI could be different than what dev observed at the time of the merge if retry completed successfully

Testing

python .github/scripts/trymerge.py --comment-id 1654010315 106095 --dry-run (need to comment out some of the code to actually write a test record to Rockset), then manually verify it with

SELECT
    *
FROM
    commons.merges
WHERE
    pr_num = 106095

to see that ignore_current_checks, broken_trunk_checks, flaky_checks, and unstable_checks shows up correctly

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106162

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 5bb86ce:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

• linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[huydhn]

As this touches find_matching_merge_rule, I have imported this to run internal tests (if any) just in case.

[clee2000]

Would it be easier to put a tuple of [job id, classification] for each job into rockset instead of separate lists for each classification?

[huydhn]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[malfet]

Forward fix in #106203, but I wonder how it escaped testing in the first place

[huydhn]

Forward fix in #106203, but I wonder how it escaped testing in the first place

I should have known. It was a landrace with my own other change #106095 (ouch)