Skip to content

Conversation

bertmaher
Copy link
Contributor

@bertmaher bertmaher commented Jul 28, 2023

Summary:
This diff has a couple of hacks to make inductor-CPU work for AOT codegen in fbcode:

  • We need to add the CUDA link flags; AOT-Inductor is specialized for CUDA
    right now and uses a lot of at::cuda stuff. We should do a proper AOT CPU
    at some point but this unblocks perf measurement.

  • Add an include path to the cpp_prefix. It's kind of hilarious; we remove the
    include path for remote execution, but then for AOT we need it back. 🤷

Test Plan: internal test

Differential Revision: D47882848

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov

Summary:
This diff has a couple of hacks to make inductor-CPU work for AOT codegen in fbcode:

- We need to add the CUDA link flags; AOT-Inductor is specialized for CUDA
  right now and uses a lot of `at::cuda` stuff.  We should do a proper AOT CPU
  at some point but this unblocks perf measurement.

- Add an include path to the cpp_prefix.  It's kind of hilarious; we remove the
  include path for remote execution, but then for AOT we need it back. 🤷

Test Plan: internal test

Differential Revision: D47882848

fbshipit-source-id: fb2eb9a70128fb6f0465e0c64ef9c9a5fd2131ac
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106225

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 83b417a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47882848

@mikekgfb
Copy link
Contributor

mikekgfb commented Aug 3, 2023

LGTM!

Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood that it is a hack. $Hack > No Solution$.

@mikekgfb
Copy link
Contributor

mikekgfb commented Aug 3, 2023

@pytorchbot merge -f "all tests passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants