[Compiled Autograd] Refactor duplicate symint handling #106234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jansel wants to merge 9 commits into gh/jansel/158/base from gh/jansel/158/head

Contributor

jansel commented Jul 28, 2023 •

edited by pytorch-bot bot

Loading

Stack from ghstack (oldest at bottom):

-> [Compiled Autograd] Refactor duplicate symint handling #106234

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @Xia-Weiwen @ngimel @anijain2305


          [Compiled Autograd] Refactor duplicate symint handling

9ca0c12

[ghstack-poisoned]

jansel mentioned this pull request

[Compiled Autograd] Remove duplicate code from double-merge #106233

Closed

pytorch-bot bot commented Jul 28, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106234

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 979d815 with merge base bcede14 ():

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 28, 2023

[Compiled Autograd] Fix duplicate visits of same node #105887

Closed

Fix FakeTensor issues with copy_ between devices #106172

Closed

[Compiled Autograd] Improve nyi error messages #106176

Closed

github-actions bot added module: inductor module: dynamo labels

jansel requested a review from voznesenskym

July 28, 2023 22:49


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

a6b62ac

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

2732a2c

ghstack-source-id: e69cfdf
Pull Request resolved: #106234


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

a726e77

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

b571dc0

ghstack-source-id: 86b9077
Pull Request resolved: #106234


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

d5fe23b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

ghstack-source-id: 2ac4a4b
Pull Request resolved: #106234


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

b84a568

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

27c563a

ghstack-source-id: c4b2f1e
Pull Request resolved: #106234

jansel mentioned this pull request

[dynamo] Treat monkey patched .forward as dynamic #107104

Closed


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

a83f2e7

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

187cd27

ghstack-source-id: 6f6d618
Pull Request resolved: #106234


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

9ad0828

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

ed60ce3

ghstack-source-id: ce00b36
Pull Request resolved: #106234


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

539d0a8

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

jansel added a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

f642394

ghstack-source-id: fac3149
Pull Request resolved: #106234

Contributor Author

jansel commented Aug 22, 2023

@pytorchbot rebase

Collaborator

pytorchmergebot commented Aug 22, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here


          Update on "[Compiled Autograd] Refactor duplicate symint handling"

979d815

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]

Collaborator

pytorchmergebot commented Aug 22, 2023

Successfully rebased gh/jansel/158/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/106234)

pytorchmergebot pushed a commit that referenced this pull request


          [Compiled Autograd] Refactor duplicate symint handling

f0c90c0

ghstack-source-id: c6c2cef
Pull Request resolved: #106234

jansel marked this pull request as draft

September 8, 2023 04:05

Contributor

github-actions bot commented Nov 7, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions bot added the Stale label

github-actions bot closed this

facebook-github-bot deleted the gh/jansel/158/head branch

January 6, 2024 15:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: dynamo module: inductor Stale