Add error inputs to ModuleInfo (mirroring OpInfo) #106325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106325
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 79db7db: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 31, 2023
[ghstack-poisoned]
mikaylagawarecki
added
topic: developer feature
ciflow/trunk
Add infra for error inputs to ModuleInfos, migrate first few error inputs tests from test_nn.py (more to come!) [ghstack-poisoned]
Add infra for error inputs to ModuleInfos, migrate first few error inputs tests from test_nn.py (more to come!) [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 1, 2023
Fixes #105627 Pull Request resolved: #106147 Approved by: https://github.com/albanD ghstack dependencies: #106325
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…06148) Fixes #105749 #95320 (tldr is that input should always be `[N, C, H, (W, D])` where only H, W and D dimensions get circular padding, so the 2D case where user wants both dimensions to be padded --> they should `.unsqueeze(0)` (as is the case for `Reflection/ReplicationPad`) but we didn't document this for circular padding. [This seems to be the old docstring](https://github.com/pytorch/pytorch/blob/277b05014aced075337d6f84a535bd5150aabebb/torch/nn/functional.py#L4689) that was somehow lost. Fixes no_batch_dim support #104860 - Adds missing documentation for circular padding - Adds missing CircularPad modules - Migrates legacy test_nn tests from circular padding to ModuleInfo - Adds no_batch_dim support + sample inputs that test this Pull Request resolved: #106148 Approved by: https://github.com/albanD ghstack dependencies: #106325, #106147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add infra for error inputs to ModuleInfos, migrate first few error inputs tests from test_nn.py (more to come!)
Stack from ghstack (oldest at bottom):