Skip to content

Conversation

voznesenskym
Copy link
Collaborator

@voznesenskym voznesenskym commented Aug 10, 2023

voznesenskym added a commit that referenced this pull request Aug 10, 2023
ghstack-source-id: 602fe99
Pull Request resolved: #106986

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106986

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4665fd6 with merge base 11602ac (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ROM"

cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
@voznesenskym voznesenskym changed the title [Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM Add support for GET_YIELD_FROM_ITER, YIELD_FROM, SEND Aug 10, 2023
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
voznesenskym added a commit that referenced this pull request Aug 11, 2023
ghstack-source-id: 2b35bac
Pull Request resolved: #106986

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback
@voznesenskym voznesenskym requested a review from jansel August 11, 2023 00:53
@ezyang ezyang removed their request for review August 11, 2023 03:57
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
voznesenskym added a commit that referenced this pull request Aug 11, 2023
ghstack-source-id: 50fb0d5
Pull Request resolved: #106986

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM
@albanD albanD removed their request for review August 11, 2023 18:57
@voznesenskym voznesenskym requested a review from jansel August 11, 2023 19:08
@voznesenskym voznesenskym added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Aug 11, 2023
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
voznesenskym added a commit that referenced this pull request Aug 14, 2023
ghstack-source-id: ab283f7
Pull Request resolved: #106986

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback
@voznesenskym
Copy link
Collaborator Author

@pytorchbot merge -f "CI passes, 3 unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 2591d17ce2322ed412b850bc08e5d01ca0fc5c26 returned non-zero exit code 1

Auto-merging test/dynamo/test_misc.py
CONFLICT (content): Merge conflict in test/dynamo/test_misc.py
error: could not apply 2591d17ce23... [Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
voznesenskym added a commit that referenced this pull request Aug 15, 2023
ghstack-source-id: 321e78a
Pull Request resolved: #106986

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
voznesenskym added a commit that referenced this pull request Aug 19, 2023
ghstack-source-id: ffa3e9f
Pull Request resolved: #106986

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback

[Dynamo x FSDP][out of stack] GET_YIELD_FROM_ITER, YIELD_FROM

Feedback

Feedback

lint
@voznesenskym
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/voznesenskym/203/head branch August 23, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants