[thread_pg] fix reduce_scatter to respect different cuda device #107152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same reason as the previous all_reduce PR, see context in the allreduce PR instead [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
fduwjj,
fegin,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107152
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit af57a65: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Add the funcol tests to multigpu tests to ensure it runs on CI Pull Request resolved: #107153 Approved by: https://github.com/kumpera ghstack dependencies: #107151, #107152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Same reason as the previous all_reduce PR, see context in the allreduce
PR #107151 instead